Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to use Node 20 #28

Closed
wants to merge 3 commits into from
Closed

Conversation

MLKendall
Copy link
Member

No description provided.

@MLKendall MLKendall requested a review from jonoliver March 20, 2024 15:15
Copy link
Member

@jonoliver jonoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the version in package-lock.json as well. But it looks like we have another issue, our current package lock file referencing sass from localhost instead of the npm registry:

"resolved": "http://localhost:4873/sass/-/sass-1.35.1.tgz",

It looks like verdaccio was being used locally, resulting in the wrong registry being erroneously committed. This causes npm install to hang and fail currently.

To fix it, I think we need to rebuild the package lock:

rm package-lock.json
rm -rf node_modules
npm install

That should fix the issue and bump the version in the package lock.

@MLKendall MLKendall force-pushed the chore/bump-to-verion-0.0.13 branch from 63c8cf1 to eb1eac1 Compare March 21, 2024 15:51
@MLKendall MLKendall force-pushed the chore/bump-to-verion-0.0.13 branch from 32807d4 to ddfb9d4 Compare March 21, 2024 16:01
Copy link
Member

@jonoliver jonoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few concerns with these updates:

  1. A version bump PR should probably be limited to only bumping the version. Code updates should be merged in a preceding PR.
  2. I think that bumping up the supported version of node warrants a major version bump. I would consider that a "breaking change" for a project using a node version below 20.

I also think I figured out the issue that was likely causing the build problems. I was able to get CI passing by installing with npm 6:

npm use 14
cd ~/.nvm/versions/node/v14.21.1/lib
npm install npm@6

After that, running npm install to update the package version, CI passed.

So here's what I'd like to do:

  1. I can create a new "Bump to 0.0.13" PR containing just the version bump
  2. This is still a valuable PR, but let's update it do describe the dependency/node version updates it's making.
  3. Merge the above two PRs sequentially
  4. Create a followup PR to bump the version to 1.0.0

I think this will give us a better level of granularity on the version bumps while respecting semver. What do you think?

@jonoliver
Copy link
Member

Created #29 to handle the 0.0.13 version bump in isolation

@MLKendall MLKendall changed the title chore: Bump to 0.0.13 feat: update to use Node 20 Mar 22, 2024
@MLKendall MLKendall marked this pull request as draft March 22, 2024 15:37
@MLKendall
Copy link
Member Author

Waiting to rebase after 0.0.13 version bump

@MLKendall
Copy link
Member Author

Closing this PR to open #30 and #31

@MLKendall MLKendall closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants