Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redirect index page for seesparkbox.com #50

Merged
merged 1 commit into from
May 28, 2024

Conversation

jonoliver
Copy link
Member

@jonoliver jonoliver commented May 28, 2024

Description
Updates the redirect rules to redirect apprentices.seesparkbox.com to apprentices.sparkbox.com. This rule works in conjunction with the CNAME record for apprentices.seesparkbox.com in DNSimple that points to the underlying Netlify site.

This update is necessary because the previous wildcard match in #49 only matched sub-pages. We don't actually have any subpages on the site any more, but the previous redirect can stay in order to redirect prior pages to sparkbox.com (eg https://apprentices.seesparkbox.com/apply-dev.html)

Validation

  1. The redirect structure can be validated by pasting the toml contents into https://redirects-playground.netlify.app/
  2. Because this requires testing the TLD and our deploy previews use the Netlify URL, there's not an easy way to test this other than merging and deploying. However, tested in production without adverse affects on apprentices.sparkbox.com.
  3. The previously added redirect behavior in chore: add redirect for seesparkbox.com #49 can be observed by visiting https://apprentices.seesparkbox.com/apply-dev.html, which will redirect to https://apprentices.sparkbox.com/.
    1. Issuing the following curl command will show that two 301 redirects are issued, first to https://apprentices.sparkbox.com/apply-dev.html (the redirect that was added in chore: add redirect for seesparkbox.com #49), then to / (the previously existing redirect).
    2. curl -Lv https://apprentices.seesparkbox.com/apply-dev.html > /dev/null

The previously added redirect only redirected sub-pages.
Copy link

netlify bot commented May 28, 2024

Deploy Preview for sb-apprentices ready!

Name Link
🔨 Latest commit 8927933
🔍 Latest deploy log https://app.netlify.com/sites/sb-apprentices/deploys/6655ffba7bb4a400075d6f0a
😎 Deploy Preview https://deploy-preview-50--sb-apprentices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonoliver jonoliver marked this pull request as ready for review May 28, 2024 16:18
@jonoliver jonoliver merged commit 8927933 into main May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant