Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#835 이벤트 종료 후 미션 달성 API 호출 관련 코드 삭제 #836

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jinhyeonkwon
Copy link
Contributor

@jinhyeonkwon jinhyeonkwon commented Sep 24, 2024

Summary

It closes #835
여러 기능에서, 미션 달성 관련 로직이 들어간 코드를 삭제했습니다.

Images or Screenshots

Further Work

  • Do something...

@jinhyeonkwon jinhyeonkwon self-assigned this Sep 24, 2024
@jinhyeonkwon jinhyeonkwon changed the title feat: delete mission-complete-related codes #835 이벤트 종료 후 미션 달성 API 호출 관련 코드 삭제 Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 86a5589
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/66f2bfc797a66a00083be76a
😎 Deploy Preview https://deploy-preview-836--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jinhyeonkwon jinhyeonkwon requested review from kmc7468, ybmin, happycastle114 and Hyogyeong8 and removed request for kmc7468 September 24, 2024 13:36
@kmc7468
Copy link
Member

kmc7468 commented Sep 24, 2024

다음 학기 이벤트를 위해, 관련 코드를 삭제하는 것보다는 주석 처리를 하거나, 또는 questComplete 훅에서 axios로 백엔드 호출하는 부분만 비활성화 하는 것도 괜찮은 방법일 것 같습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 이벤트 종료 후, 미션 달성 API 호출 관련 버그
2 participants