-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#784 송금하지 않은 방이 있는 경우 추가 방 참여 제한 #787
Merged
The head ref may contain hidden characters: "#784-\uBBF8\uC815\uC0B0-\uBC29\uC774-\uC788\uB294-\uACBD\uC6B0-\uCD94\uAC00-\uBC29-\uCC38\uC5EC-\uC81C\uD55C"
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
746410d
Add : Prevent entering new room when paying is not complete
jinhyeonkwon 98db18a
Add : Prevent room creation when paying is not complete, and fix some…
jinhyeonkwon 2325074
Refactor: Using useMemo
jinhyeonkwon ec12eca
Refactor: used useMemo to notPaid
jinhyeonkwon 0e64ffa
Merge branch 'dev' into #784-미정산-방이-있는-경우-추가-방-참여-제한
jinhyeonkwon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이번 PR에서 방 타입 정의가 같이 이루어져도 괜찮을 것 같네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
회의 논의 결과, 백엔드가 TS로 넘어가면 타입 공유를 해서 쓰는걸로 결정했습니다.