Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove error Code Check #69

Conversation

happycastle114
Copy link
Collaborator

Summary

It closes #62

인터넷 연결 실패시 에러페이지를 띄웁니다.

https://developer.android.com/reference/android/webkit/WebViewClient

@happycastle114 happycastle114 linked an issue Aug 23, 2023 that may be closed by this pull request
@happycastle114 happycastle114 self-assigned this Aug 23, 2023
@happycastle114 happycastle114 added the bug Something isn't working label Aug 23, 2023
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isServerError 가 어떤 변수인지 설명해 주실 수 있을까요?

@happycastle114
Copy link
Collaborator Author

@sboh1214
isServerError 자체는 Error Dialog를 띄울지 말지 결정하는 State입니다!

기존에는 Error Code -2 (ERROR_HOST_LOOKUP) 상황에서만 Error Dialog를 띄웠는데, https://developer.android.com/reference/android/webkit/WebViewClient 에 정의된 에러가 발생했을 때 전부 띄우도록 수정했습니다 ! ( 전부 연결에 실패했을 때 뜨는 에러라서.. )

Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@happycastle114 happycastle114 merged commit d9ec8c5 into main Sep 7, 2023
2 checks passed
@happycastle114 happycastle114 deleted the #62-인터넷-연결-실패-시-에러-페이지-띄우기 branch September 7, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 인터넷 연결 실패 시 에러 페이지 띄우기
3 participants