-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create notification FastAPI #468
base: develop
Are you sure you want to change the base?
Changes from 1 commit
a47a2e8
c8b7d65
7298e37
f562ccc
32cba7f
41da2ef
c228e10
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
from apps.core.models import Article, Comment, Notification, NotificationReadLog | ||
from apps.core.models.board import NameType | ||
from ara.domain.notification.type import NotificationInfo | ||
from ara.firebase import fcm_notify_comment | ||
from ara.infra.django_infra import AraDjangoInfra | ||
|
||
|
||
class NotificationInfra(AraDjangoInfra[Notification]): | ||
def __init__(self, user_id: int) -> None: | ||
def __init__(self) -> None: | ||
super().__init__(Notification) | ||
self.user_id = user_id | ||
|
||
def get_all_notifications(self, user_id: int) -> list[NotificationInfo]: | ||
queryset = Notification.objects.select_related( | ||
|
@@ -18,9 +19,19 @@ def get_all_notifications(self, user_id: int) -> list[NotificationInfo]: | |
) | ||
return [self._to_notification_info(notification) for notification in queryset] | ||
|
||
def get_unread_notifications(self, user_id: int) -> list[NotificationInfo]: | ||
notifications = self.notification_infra.get_all_notifications(user_id) | ||
return [ | ||
notification | ||
for notification in notifications | ||
if NotificationReadLog.objects.filter( | ||
notification=notification, read_by=user_id, is_read=False | ||
).exists() | ||
] | ||
|
||
def _to_notification_info(self, notification: Notification) -> NotificationInfo: | ||
return NotificationInfo( | ||
id=notification.id, # 이렇게 써도 되나요? | ||
id=notification.id, | ||
type=notification.type, | ||
title=notification.title, | ||
content=notification.content, | ||
|
@@ -43,26 +54,76 @@ def read_notification(self, user_id: int, notification_id: int) -> None: | |
notification_read_log.is_read = True | ||
notification_read_log.save() | ||
|
||
""" | ||
##수정해야함## | ||
|
||
def create_notification(self, article: Article, comment: Comment) -> None: | ||
if comment.parent_comment: | ||
parent_comment = comment.parent_comment | ||
related_comment = parent_comment | ||
def get_display_name(self, article: Article, profile: int): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이거는 외부로 노출(domain 이나 다른 infra layer에서 사용할거 같아 보이는게 아닌)되지 않으면 함수명에 _ 붙여 주세요 |
||
if article.name_type == NameType.REALNAME: | ||
return "실명" | ||
elif article.name_type == NameType.REGULAR: | ||
return "nickname" | ||
else: | ||
related_comment = None | ||
return "익명" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "실명", "nickname", "익명" 전부다 constant로 지정해서 사용해주세요!!!! |
||
|
||
def create_notification(self, comment: Comment) -> None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이거 transaction이 붙어야 할거 같아요 음... 근데 이거는 어려울 수도 있으니까 같이 한번 봐요 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 넵~! |
||
def notify_article_commented(_parent_article: Article, _comment: Comment): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 변수에 왜 _가 들어있나요? |
||
name = self.get_display_name(_parent_article, _comment.created_by_id) | ||
title = f"{name} 님이 새로운 댓글을 작성했습니다." | ||
|
||
notification = Notification( | ||
type="article_commented", | ||
title=title, | ||
content=_comment.content[:32], | ||
related_article=_parent_article, | ||
related_comment=None, | ||
) | ||
notification.save() | ||
|
||
NotificationReadLog.objects.create( | ||
read_by=_parent_article.created_by, | ||
notification=notification, | ||
) | ||
|
||
related_article = comment.parent_article if comment.parent_article else parent_comment.parent_article | ||
fcm_notify_comment( | ||
_parent_article.created_by, | ||
title, | ||
_comment.content[:32], | ||
f"post/{_parent_article.id}", | ||
) | ||
|
||
title = f"{article.title}에 새로운 {'대댓글' if parent_comment else '댓글'}이 작성되었습니다." | ||
content = comment.content[:32] | ||
def notify_comment_commented(_parent_article: Article, _comment: Comment): | ||
name = self.get_display_name(_parent_article, _comment.created_by_id) | ||
title = f"{name} 님이 새로운 대댓글을 작성했습니다." | ||
|
||
Notification.objects.create( | ||
type="comment_commented" if parent_comment else "article_commented", | ||
title=title, | ||
content=content, | ||
related_article=related_article, | ||
related_comment=related_comment, | ||
notification = Notification( | ||
type="comment_commented", | ||
title=title, | ||
content=_comment.content[:32], | ||
related_article=_parent_article, | ||
related_comment=_comment.parent_comment, | ||
) | ||
notification.save() | ||
|
||
NotificationReadLog.objects.create( | ||
read_by=_comment.parent_comment.created_by, | ||
notification=notification, | ||
) | ||
|
||
fcm_notify_comment( | ||
_comment.parent_comment.created_by, | ||
title, | ||
_comment.content[:32], | ||
f"post/{_parent_article.id}", | ||
) | ||
|
||
article = ( | ||
comment.parent_article | ||
if comment.parent_article | ||
else comment.parent_comment.parent_article | ||
) | ||
""" | ||
|
||
if comment.created_by != article.created_by: | ||
notify_article_commented(article, comment) | ||
|
||
if ( | ||
comment.parent_comment | ||
and comment.created_by != comment.parent_comment.created_by | ||
): | ||
notify_comment_commented(article, comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 N+1 쿼리일 가능성이 높아 보이는데 시간 나면 리팩토링 하거나 TODO 체크해주세요 👍