Web push notification w/ FCM topic #368
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injoonH
reviewed
Feb 1, 2023
apps/user/views/fcm.py
Outdated
| elif mode == "update": | ||
| if not request.user.is_authenticated: | ||
| return Response(status=status.HTTP_401_UNAUTHORIZED) | ||
| token = FCMToken(token=token, user=request.user, last_activated_at=Now()) |
There was a problem hiding this comment.
기존 다른 코드들에서는 django.utils.timezone.now()를 사용했었는데 django.db.models.functions.Now()도 있었군요. 쿼리가 실행되었을 당시의 서버의 날짜와 시각을 반환한다고 하는데 timezone 문제가 발생하지는 않을지 여쭙습니다.
There was a problem hiding this comment.
오.. 그 부분은 생각을 못했었어요 last_activated_at 이 그렇게 중요한 컬럼은 아니라서 django.utils.timezone.now() 로 바꾸어도 될 것 같아요
There was a problem hiding this comment.
이 Stack Overflow에서 두 차이를 설명하고 있는데 일단은 혹시 모르니 django.utils.timezone.now()를 사용합시다.
|
리뷰 반영했습니다. 우선 아래 이유로 지금 당장 머지할수는 없어서 해결이 된다면 머지를 하겠습니다.
|
injoonH
approved these changes
Feb 15, 2023
retroinspect
force-pushed
the
feature/fcm-topic
branch
from
a94b1b1
to
a31b4df
Compare
retroinspect
force-pushed
the
feature/fcm-topic
branch
from
a31b4df
to
4f0831a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 티켓
Feature
TODO 라고 되어 있는 부분 의견 있으시면 알려주세요!