Add knob to turn off auto precedence for Events #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingaard
approved these changes
Oct 27, 2024
sparta/sparta/simulation/Unit.hpp
Outdated
| @@ -125,6 +125,12 @@ namespace sparta { | |||
|
|
|||
| for(auto & event_node : unit_event_set_.getEvents(sparta::SchedulingPhase::Tick)) | |||
| { | |||
| // This EventNode does not participate auto precedence | |||
| // between InPorts and OutPorts. | |||
furuame
commented
Oct 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Add knob to turn off auto precedence for Events * Comment tweaks d03a7fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a method for InPorts and OutPorts to turn off auto precedence in Sparta Unit. However, it would also be good to have a similar method but only effective on Events.