Added in ability to specify a content_width for ColumnViews #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingaard
added
the
component: pipeViewer
klingaard
reviewed
Apr 27, 2024
| @@ -266,6 +266,7 @@ def __init__(self, | |||
| spacing, | |||
| margins, | |||
| include_detail_column : bool, | |||
| content_width : int, | |||
There was a problem hiding this comment.
To allow backward compatibility, can you swap the order of the new param with time_offset?
There was a problem hiding this comment.
I think I got them all -- can you double-check, since I don't know python?
bdutro
approved these changes
Apr 29, 2024
klingaard
approved these changes
Apr 29, 2024
|
I can't merge this, since I don't have write access. Could one of you two do it? Thx. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.