Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALFLayout Generator #442

Merged
5 commits merged into from
Sep 21, 2023
Merged

ALFLayout Generator #442

5 commits merged into from
Sep 21, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 20, 2023

New python script that replaces the old, outdated perl generator.

This new generator consumes a location.dat file from a generated pipeout and, when coupled with a custom python script, can be used to explicitly setup ALF files used by the Argos tools.

See pydoc ALFLayout for more information as well as the example in example.CoreModel

@ghost ghost added enhancement Enhancement or request component: sparta Issue is related to sparta framework component: pipeViewer Issue is related to the Helios Pipeline Viewer labels Sep 20, 2023
@ghost ghost self-assigned this Sep 20, 2023
@kathlenehurt-sifive
Copy link
Contributor

I'd recommend adding a main function in gen_layouts.py incase you ever want to add command line parameters.

Copy link
Contributor

@kathlenehurt-sifive kathlenehurt-sifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@ghost
Copy link
Author

ghost commented Sep 20, 2023

I'd recommend adding a main function in gen_layouts.py incase you ever want to add command line parameters.

Not a bad idea. Wish I were a better python programmer. Not sure what I'd do with a main. 😄

@ghost ghost merged commit 2adb710 into master Sep 21, 2023
8 checks passed
@ghost ghost deleted the knutel/alf_generator branch September 21, 2023 12:56
github-actions bot pushed a commit that referenced this pull request Sep 21, 2023
* Swapped out the old perl gen alf for new Python one
* Updated example for creating an ALF
* Fixed CoreExample testing failures with the new ALF 2adb710
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pipeViewer Issue is related to the Helios Pipeline Viewer component: sparta Issue is related to sparta framework enhancement Enhancement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant