Make all single-argument StatisticInstance constructors explicit

Change StatAdder operator() to take const TreeNode* instead of TreeNode*
sparcians · May 2, 2024 · 6944bdb · 6944bdb
1 parent c4d456b
commit 6944bdb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/sparta/sparta/report/Report.hpp b/sparta/sparta/report/Report.hpp
@@ -379,7 +379,7 @@ namespace sparta
                 r_.add(ctr, name);
                 return *this;
             }
-            StatAdder& operator()(TreeNode* n,
+            StatAdder& operator()(const TreeNode* n,
                                   const std::string& name="") {
                 r_.add(n, name);
                 return *this;

diff --git a/sparta/sparta/statistics/StatisticInstance.hpp b/sparta/sparta/statistics/StatisticInstance.hpp
@@ -44,7 +44,7 @@ namespace sparta
          * \note Stream insertion operator can be used to add more text to the
          * reason.
          */
-        ReversedStatisticRange(const std::string & reason) :
+        explicit ReversedStatisticRange(const std::string & reason) :
             SpartaException(reason)
         { }
 
@@ -67,7 +67,7 @@ namespace sparta
          * \note Stream insertion operator can be used to add more text to the
          * reason.
          */
-        FutureStatisticRange(const std::string & reason) :
+        explicit FutureStatisticRange(const std::string & reason) :
             SpartaException(reason)
         { }
 
@@ -128,15 +128,15 @@ namespace sparta
          * \note You *must* set the context (setContext) after this
          *       call.  The Expression might or might not know the context for the Scheduler
          */
-        StatisticInstance(statistics::expression::Expression&& expr) :
+        explicit StatisticInstance(statistics::expression::Expression&& expr) :
             stat_expr_(expr)
         { }
 
         /*!
          * \brief Construct with a StatisticDef or Counter as a TreeNode*
          * \param node Must be an interface to a StatisticDef or a Counter
          */
-        StatisticInstance(const TreeNode* node) :
+        explicit StatisticInstance(const TreeNode* node) :
             StatisticInstance(nullptr, nullptr, nullptr, node, nullptr)
         { }