-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't silence errors on span update calls #90
Conversation
I've settled on accepting that some calls silently ignore errors, and have illustrated that behavior in tests and in documentation. |
Pull Request Test Coverage Report for Build 4ddad899-ed81-48d2-85a9-a30ba6d98f6c
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, just a bunch of nitpicks. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addresses some but not all of the issues in #65. I'm still not sure how we should return from
start_trace
start_span
finish_trace
finish_span
and thecontinue_*
functions if given invalid updates. Its been discussed in slack, and we probably shouldn't just skip starting the span, and we also should raise an error. Likewise, returning{:error, error}
but still starting the trace/span might be wrong. Really not sure of the best path forward there.