Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't silence errors on span update calls #90

Merged
merged 3 commits into from
Nov 27, 2018

Conversation

zachdaniel
Copy link
Member

This addresses some but not all of the issues in #65. I'm still not sure how we should return from start_trace start_span finish_trace finish_span and the continue_* functions if given invalid updates. Its been discussed in slack, and we probably shouldn't just skip starting the span, and we also should raise an error. Likewise, returning {:error, error} but still starting the trace/span might be wrong. Really not sure of the best path forward there.

@zachdaniel
Copy link
Member Author

I've settled on accepting that some calls silently ignore errors, and have illustrated that behavior in tests and in documentation.

@coveralls
Copy link

coveralls commented Nov 26, 2018

Pull Request Test Coverage Report for Build 4ddad899-ed81-48d2-85a9-a30ba6d98f6c

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 83.399%

Totals Coverage Status
Change from base Build 971d501c-6d07-4be5-bc75-90c95cf7afb9: 0.9%
Covered Lines: 211
Relevant Lines: 253

💛 - Coveralls

Copy link
Member

@GregMefford GregMefford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, just a bunch of nitpicks. 😁

lib/spandex.ex Outdated Show resolved Hide resolved
lib/spandex.ex Outdated Show resolved Hide resolved
lib/spandex.ex Outdated Show resolved Hide resolved
lib/spandex.ex Outdated Show resolved Hide resolved
lib/spandex.ex Outdated Show resolved Hide resolved
lib/spandex.ex Outdated Show resolved Hide resolved
lib/spandex.ex Outdated Show resolved Hide resolved
lib/spandex.ex Outdated Show resolved Hide resolved
lib/spandex.ex Outdated Show resolved Hide resolved
lib/spandex.ex Outdated Show resolved Hide resolved
Copy link
Member

@GregMefford GregMefford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zachdaniel zachdaniel merged commit b2f6633 into master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants