change approved notification comment

README.md

@@ -2,26 +2,10 @@
 
 This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 12.0.2.
 
-## Development server
+## Chrome Web Store deployment instructions
 
-Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The app will automatically reload if you change any of the source files.
-
-## Code scaffolding
-
-Run `ng generate component component-name` to generate a new component. You can also use `ng generate directive|pipe|service|class|guard|interface|enum|module`.
-
-## Build
-
-Run `ng build` to build the project. The build artifacts will be stored in the `dist/` directory.
-
-## Running unit tests
-
-Run `ng test` to execute the unit tests via [Karma](https://karma-runner.github.io).
-
-## Running end-to-end tests
-
-Run `ng e2e` to execute the end-to-end tests via a platform of your choice. To use this command, you need to first add a package that implements end-to-end testing capabilities.
-
-## Further help
-
-To get more help on the Angular CLI use `ng help` or go check out the [Angular CLI Overview and Command Reference](https://angular.io/cli) page.
+- increment extension's version in the `manifest.json` file
+- run `npm run build:prod` command
+- zip output folder, so the `manifest.json` is in the root
+- upload zip file to the webstore developer dashboard
+- submit for review

src/app/other/notification.titles.ts

@@ -2,7 +2,7 @@ import {PullRequestActivityAction} from '../models/enums';
 import {NotificationOptions} from '../models/models';
 
 export function GetSlackNotificationTitle(options: NotificationOptions): string {
-  // todo: move :reaction: names to settings
+  // todo: move :reaction: emoji names to settings
   let title;
   switch (options.action) {
     case PullRequestActivityAction.Commented:
@@ -12,7 +12,7 @@ export function GetSlackNotificationTitle(options: NotificationOptions): string
       title = `:pull_request: @${options.pullRequest.author.user.name} assigned you a new pull request`;
       break;
     case PullRequestActivityAction.Approved:
-      title = ':white_check_mark: Your pull request approved';
+      title = `:white_check_mark: @${options.activity?.user.name} approved your pull request`;
       break;
     case PullRequestActivityAction.Merged:
       title = `:merged: @${options.activity?.user.name} merged pull request`;