fix slack notification message when PR got approved

spaduret · Jan 16, 2024 · 4d48300 · 4d48300
1 parent 1708550
commit 4d48300
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/app/other/notification.titles.ts b/src/app/other/notification.titles.ts
@@ -12,7 +12,11 @@ export function GetSlackNotificationTitle(options: NotificationOptions): string
       title = `:pull_request: @${options.pullRequest.author.user.name} assigned you a new pull request`;
       break;
     case PullRequestActivityAction.Approved:
-      title = `:white_check_mark: @${options.activity?.user.name} approved your pull request`;
+      const users = options.pullRequest.reviewers
+        .filter(r => r.approved)
+        .map(a => `@${a.user.name}`)
+        .join(', ');
+      title = `:white_check_mark: ${users} approved your pull request`;
       break;
     case PullRequestActivityAction.Merged:
       title = `:merged: @${options.activity?.user.name} merged pull request`;