Add utilities to automatically download external data #178
+107
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WEBBPSF has the annoying issue that it requires a manual download of external data fils to be able to function along with an environment variable set to point at that data. This is a huge pain, so I am adding a little utility to check for the environment variable, set it to the recommended default if it is not present and then download the data files if they do not exist. This is done in a way that the files will persist on disk and not be downloaded more than once.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 89.24% 91.15% +1.91%
==========================================
Files 17 16 -1
Lines 2073 2137 +64
==========================================
+ Hits 1850 1948 +98
+ Misses 223 189 -34 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
This is going to start running these a few times for every test run? I get a little worried we're going to get rate limited eventually, but maybe that's okay. I don't understand the build system well, but is there an alternative where the [test] dependency triggers automatically grabbing these files and putting them in some romanisim-specific directory? I'm also a little leery of messing with $HOME/data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webbpsfand thegalsimcatalog data have to be downloaded independently of installingromanisim[test]. These however are required for the tests. I find this rather annoying so, this PR contrives some utilities that download the data if it hasn't been already.