Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the MA tables in parameters.py and setting the default MAtable to 4 in ris_make_utils.py #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eunkyuh
Copy link

@eunkyuh eunkyuh commented Nov 20, 2024

  • Updating the MA tables within parameters.py to match PRD15. Excluded 3 MA tables: 1(DEFOCUS_MOD), 2(DEFOCUS_LRG), and 18(DIAGNOSTIC)

  • Updating rist_make_utils.py to change the default MA table to 4 as the previous selection of MA table Initial functional simulator commit #1 is not available anymore.

@eunkyuh eunkyuh requested a review from a team as a code owner November 20, 2024 17:20
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (81028a8) to head (787e370).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   89.24%   91.04%   +1.80%     
==========================================
  Files          17       16       -1     
  Lines        2073     2100      +27     
==========================================
+ Hits         1850     1912      +62     
+ Misses        223      188      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@schlafly
Copy link
Collaborator

Thanks, this looks good. It looks like some of the tests still use the old default MA table as 1, so the unit tests are failing. I'm sympathetic to deleting that MA table (as you do in this PR), but then please update the tests as well. Alternatively, leave in the old MA table 1 so that the tests still pass, but continue to update the default as you are doing.

Thanks!

@eunkyuh eunkyuh force-pushed the romanisim_han branch 5 times, most recently from db84b66 to ba095a3 Compare November 23, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants