Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove upper pin from requires-python #167

Merged

Conversation

zacharyburnett
Copy link
Collaborator

No description provided.

@zacharyburnett zacharyburnett self-assigned this Oct 21, 2024
@zacharyburnett zacharyburnett changed the title unpin Python remove upper pin from requires-python Oct 21, 2024
@zacharyburnett
Copy link
Collaborator Author

It looks like we're still in a limbo state, where the Linux runner grabs Python 3.12 as "latest 3" but the macOS runner grabs Python 3.13

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (81028a8) to head (2054709).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   89.24%   91.07%   +1.83%     
==========================================
  Files          17       16       -1     
  Lines        2073     2118      +45     
==========================================
+ Hits         1850     1929      +79     
+ Misses        223      189      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator

Tests passing, so I guess you can go ahead and un-draft it and I'll merge? Thanks!

@zacharyburnett zacharyburnett marked this pull request as ready for review October 21, 2024 18:02
@zacharyburnett zacharyburnett requested a review from a team as a code owner October 21, 2024 18:02
@zacharyburnett zacharyburnett merged commit 326fe0a into spacetelescope:main Oct 21, 2024
20 checks passed
@zacharyburnett zacharyburnett deleted the deps/unpin_python branch October 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants