-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update romanisim to use the new L1 / L2 metadata #166
Update romanisim to use the new L1 / L2 metadata #166
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
+ Coverage 89.24% 91.00% +1.76%
==========================================
Files 17 16 -1
Lines 2073 2102 +29
==========================================
+ Hits 1850 1913 +63
+ Misses 223 189 -34 ☔ View full report in Codecov by Sentry. |
@PaulHuwe , I think this is basically working; tests are currently failing because BORESIGHT / WFI_CEN / CGI_CEN aren't allowed aperture names, but I think we want to add those to the allowed list. When the new rad/rdm PRs go in we'll want to use this PR to make the L1 data that can be used for the romancal regression tests. |
Okay, this is now ready to go when we merge the rad/rdm changes. |
We are updating the metadata in rad/rdm for L1 and L2 files. This updates romanisim to use that new metadata format. It also changes the file names to use wfi in lowercase rather than uppercase.