RCAL-832 L3 Generation #137
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 89.95% 89.24% -0.72%
==========================================
Files 17 17
Lines 1792 2073 +281
==========================================
+ Hits 1612 1850 +238
- Misses 180 223 +43 ☔ View full report in Codecov by Sentry. |
…omanisim into RCAL-832_L3Generation
|
@zacharyburnett I have been trying to debug the failures above, to no avail. Is this something you can shed some light one? |
|
ah, both EDIT: upon further inspection it looks like the check is in |
There was a problem hiding this comment.
I left a few comments inline. I think I would delete the two tests involving comparisons against 20**2 * max(image), and I think you should get the build working, probably by removing the pixel_scale bit that depends on webbpsf. Don't worry about the other comments; I'll take it from here.
| if bandpass is None: | ||
| bandpass = roman.getBandpasses(AB_zeropoint=True)[galsim_filter_name] | ||
|
|
||
| # Create initial galsim image (x & y are flipped) |
There was a problem hiding this comment.
I don't think these are actually flipped? https://galsim-developers.github.io/GalSim/_build/html/image_class.html (ncol, nrow) sounds like ny, nx to me, which is the same as shape?
| sky_level = roman.getSkyLevel(bandpass, world_pos=mos_cent_pos, exptime=1) | ||
| sky_level *= (1.0 + roman.stray_light_fraction) | ||
| sky_mosaic = image * 0 | ||
| wcs.makeSkyImage(sky_mosaic, sky_level) |
There was a problem hiding this comment.
One subtlety I hadn't though about now is that makeSkyImage makes images in electrons / pixel. L3 skies can have weird pixel sizes and should be in MJy / sr. So there are probably some conversions here to get this right.
|
Great, thanks. Can you also confirm what is intended for the L3 test with the 20**2, and then let's go ahead and merge? |
|
just one warning when building the docs now: |
This ticket adds Level 3 Mosaic simulation and tests.