-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional progress bar display during PSF and datacube calculations #605
Add optional progress bar display during PSF and datacube calculations #605
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #605 +/- ##
===========================================
+ Coverage 74.44% 74.45% +0.01%
===========================================
Files 18 18
Lines 6645 6656 +11
===========================================
+ Hits 4947 4956 +9
- Misses 1698 1700 +2 ☔ View full report in Codecov by Sentry. |
ef7f9e9
to
67ec1e0
Compare
@obi-wan76 @BradleySappington Good morning, I realized I never tagged anyone to review this PR from some months ago. This adds a minor 'quality of life' improvement to optionally display progress bars during long calculations. Hopefully straightforward for one of you to review, thanks. |
67ec1e0
to
f77dfdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used tqdm before, what an elegant solution! Nice work
@BradleySappington yeah tqdm is quite nice. It makes it super easy to add a progress bar to any for loop or other iteration. The actual progress bar display part of this PR is tiny and succinct compared to the extra contortions I put in to make it optional and configurable with a function parameter. 😆 |
@mperrin Lol, such is the way, "Yes, this works so easy!....now work for me..." |
Minor. Adds a
progressbar
bool parameter for displaying a progress bar for status during long PSF or datacube calculations using the optical systemcalc_psf
or instrument classcalc_datacube
functions.Requires optional dependency tqdm, which I have intentionally not made a required dependency as part of this PR, since this is an optional feature for a cosmetic display during calculations, not otherwise used anywhere within poppy.