Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Various issues with CI actions #592

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

BradleySappington
Copy link
Collaborator

Had to update minimum version of astropy
Update syntax on negative complex numbers causing freznel.py tests to fail

@BradleySappington
Copy link
Collaborator Author

BradleySappington commented Oct 13, 2023

@braingram , this update should fix PR #585

@BradleySappington BradleySappington self-assigned this Oct 13, 2023
Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these fixes. Seeing the changes I now understand why the tests were failing on #585
I tested (locally) the changes in #585 and in this PR and the py310-numexpr-mkl-cov tests pass. LGTM!

Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@BradleySappington BradleySappington merged commit eee741a into spacetelescope:develop Oct 13, 2023
6 checks passed
@BradleySappington BradleySappington deleted the ci_fix branch October 13, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants