Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PyPI upload workflow from OpenAstronomy #590

Merged

Conversation

zacharyburnett
Copy link
Contributor

Resolves SCSB-108

This PR changes the PyPI upload process to use the OpenAstronomy workflow instead of the STScI one. The workflow in this PR is configured to test the build with each pull request push, and then publish upon an official release.

@zacharyburnett zacharyburnett marked this pull request as ready for review October 4, 2023 18:25
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fa90e1) 74.13% compared to head (c3ecdd6) 74.13%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #590   +/-   ##
========================================
  Coverage    74.13%   74.13%           
========================================
  Files           18       18           
  Lines         6558     6558           
========================================
  Hits          4862     4862           
  Misses        1696     1696           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradleySappington
Copy link
Collaborator

@zacharyburnett - If you rebase, this PR should pass tests (can't speak for codecov)

@mperrin
Copy link
Collaborator

mperrin commented Dec 11, 2023

I was reminded of this open PR. @zacharyburnett could you rebase this on current develop please, as @BradleySappington suggested a while back, so we can see if that gets the CI passing? Or I can do so myself if you concur it's OK for me to rebase and push to your PR branch (assuming "allow edits from maintainers" is enabled)?

@zacharyburnett
Copy link
Contributor Author

sure thing, sorry this must have slipped through my notifications

@mperrin
Copy link
Collaborator

mperrin commented Dec 20, 2023

@BradleySappington you approved the version of this PR in the webbpsf repo. I assume this is all good to approve here in poppy as well?

@BradleySappington BradleySappington merged commit 7d71302 into spacetelescope:develop Dec 20, 2023
9 checks passed
@zacharyburnett zacharyburnett deleted the ci/openastronomy branch December 20, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants