Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed XFAIL marker as tests are xpassing #1646

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

mdlpstsci
Copy link
Collaborator

Tests marked as xfail are actually passing (xpass), so removed the xfail marker.

@mdlpstsci mdlpstsci added code cleanup Code refactoring, cleanup of temporary code no-changelog-entry-needed jirahub-ignore Avoid linking to Jira labels Aug 15, 2023
@mdlpstsci mdlpstsci self-assigned this Aug 15, 2023
@mdlpstsci mdlpstsci requested a review from a team as a code owner August 15, 2023 21:24
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -4.51% ⚠️

Comparison is base (7fe0212) 36.90% compared to head (3971fb0) 32.40%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1646      +/-   ##
==========================================
- Coverage   36.90%   32.40%   -4.51%     
==========================================
  Files         159      159              
  Lines       35067    35046      -21     
  Branches     5794        0    -5794     
==========================================
- Hits        12943    11355    -1588     
- Misses      21768    23691    +1923     
+ Partials      356        0     -356     
Files Changed Coverage Δ
tests/acs/test_acs_tweak.py 12.08% <ø> (-1.90%) ⬇️
tests/acs/test_unit.py 8.02% <ø> (-0.31%) ⬇️

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdlpstsci
Copy link
Collaborator Author

Just removing xfail markers.

@mdlpstsci mdlpstsci merged commit 10da8cc into spacetelescope:master Aug 15, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Code refactoring, cleanup of temporary code jirahub-ignore Avoid linking to Jira no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant