Drizzlepac: Ensure the "best" WCS solution is found when using a set #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1638 +/- ##
=======================================
Coverage 32.39% 32.39%
=======================================
Files 159 159
Lines 35047 35047
=======================================
Hits 11355 11355
Misses 23692 23692
☔ View full report in Codecov by Sentry. |
raswaters
approved these changes
Aug 11, 2023
|
Merging as the PyTest file which is causing the failure is known (test_svm_hrcsbc.py) and will be fixed in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the wcs_preference string more explicit as to the priority order of the common desired WCS solution when selecting from a set. This was necessary as there are six possibilities at this time (e.g., GAIAeDR3, GAIADR2, and GAIADR1 for REL and IMG alignment) for matching to GAIA, and the most up-to-date GAIA solution is what is wanted.
Note: The case of the WCS solutions is not altered (to upper- or lower-case) throughout the source code.