Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rmap tickets for JWST build 10.0 #956

Merged
merged 8 commits into from
Sep 7, 2023
Merged

Rmap tickets for JWST build 10.0 #956

merged 8 commits into from
Sep 7, 2023

Conversation

hbrown-ST
Copy link
Collaborator

This PR contains changes for CCD-1360, 1361 and 1362.

'filetype' : 'INTERPIXEL CAPACITANCE',
'instrument' : 'MIRI',
'mapping' : 'REFERENCE',
'name' : 'miri_ipc.rmap',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not positive about the names I'm giving them, since other rmaps tend to list out full examples like
"'name' : 'jwst_nirspec_wavelengthrange_0000.rmap'," for nirspec_wavelengthrange.rmap,
meanwhile others are simplified like the ones I provided, as in:
"'name' : 'nircam_superbias.rmap'," for nircam_superbias.rmap.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this level, the name is not really relevant. More generic is preferred only because these are just for validation, and the name field is not involved. For a solid rule, it should be the name of the the actual file itself.

@@ -8,8 +8,8 @@ header = {
'mapping' : 'REFERENCE',
'name' : 'jwst_miri_apcorr.rmap',
'observatory' : 'JWST',
'parkey' : (('META.EXPOSURE.TYPE',), ('META.OBSERVATION.DATE', 'META.OBSERVATION.TIME')),
'sha1sum' : 'e2255db2e45b01b85aa4686d6e1811ad77ff33b8',
'parkey' : (('META.EXPOSURE.TYPE', 'META.INSTRUMENT.CHANNEL'), ('META.OBSERVATION.DATE', 'META.OBSERVATION.TIME')),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the parkey tuple needs to have it's second setting match, so not sure this is in the right place or if I need a third tuple for just META.INSTRUMENT parkeys.

@hbrown-ST hbrown-ST merged commit da60147 into master Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants