Implements List Input + Error Cleanup #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not inconcievable to want to cut more then one directory in one go, particulary in the case of downstreams. I'm not 100% that we should be avoiding just targeting the whole project in cases like ss13, but a list input is pretty easy to implement so may as well. I am considering doing the same thing to the templates string but that is mildly more complex.
We were defining a new error type and then casting it to another, different error type immediately. There's no reason to do this because we have an existing error type system that handles this kind of casting better. Should just be usin that
LemonInTheDark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not inconcievable to want to cut more then one directory in one go, particulary in the case of downstreams.
I'm not 100% that we should be avoiding just targeting the whole project in cases like ss13, but a list input is pretty easy to implement so may as well.
I am considering doing the same thing to the templates string but that is mildly more complex.