fix: check for register platform v2 mutation #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-hontarau
commented
Dec 9, 2024
| @@ -20,6 +21,11 @@ func createVersion() cli.ActionFunc { | |||
|
|
|||
| providerType := cliCtx.String(flagProviderType.Name) | |||
| useRegisterPlatformV2 := cliCtx.Bool(flagUseRegisterPlatformV2.Name) | |||
There was a problem hiding this comment.
probably we can remove this flag, I think it wasnt released
There was a problem hiding this comment.
I vote on removing it in this PR
adamconnelly
approved these changes
Dec 9, 2024
eliecharra
approved these changes
Dec 9, 2024
ilya-hontarau
deleted the
feat-check-for-register-platform-v2-mutation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introspection is used to determine whether we want to use the registerPlatformV2 mutation or not.
Follow up of this PR #273