Fix spacectl race on terminal state when reading logs (#58)

spacelift-io · May 2, 2022 · b017e9f · b017e9f
1 parent a05faa4
commit b017e9f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/internal/cmd/stack/run_logs.go b/internal/cmd/stack/run_logs.go
@@ -17,6 +17,7 @@ func runLogs(ctx context.Context, stack, run string) (terminal *structs.RunState
 
 	go func() {
 		terminal, err = runStates(ctx, stack, run, lines)
+		close(lines)
 	}()
 
 	for line := range lines {
@@ -27,8 +28,6 @@ func runLogs(ctx context.Context, stack, run string) (terminal *structs.RunState
 }
 
 func runStates(ctx context.Context, stack, run string, sink chan<- string) (*structs.RunStateTransition, error) {
-	defer func() { close(sink) }()
-
 	var query struct {
 		Stack *struct {
 			Run *struct {