Small fix for global posts leading to "directorist_author_profile" shortcut-page #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our theme (typer) url to author profile is taken not from login but from "user_nicename". So everything I needed to do is to add is get_user_by( 'slug', $user_id) in addition to existing get_user_by( 'login', $user_id). But if "get user_by()" doesn't find matching user (with \WP_User::get_data_by( $field, $user_id )) it just returns current user (making "get_current_user_id()" in the function redundant). So I made a small refactor to make code cleaner and add slug check
AbyssWaIker
changed the title
|
Turned out my entire use-case was based on the fact that "regenerate page" has overriden "front user profile" page... Still, this little commit makes code a bit more readable, maintanable and prepared for links in wp's "user_nicename" format (specifically made to be url-friendly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our theme (typer) url to author profile is taken not from login but from "user_nicename".
So everything I needed to do is to add is get_user_by( 'slug', $user_id) in addition to existing get_user_by( 'login', $user_id).
But if "get user_by()" doesn't find matching user (with \WP_User::get_data_by( $field, $user_id )) it just returns current user (making "get_current_user_id()" in the function redundant).
So I made a small refactor to make code cleaner and add slug check