-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix port sorting in generated firewall rules file #291
Open
igolman
wants to merge
10
commits into
sous-chefs:main
Choose a base branch
from
igolman:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damacus
added
the
Release: Patch
Release to Chef Supermarket as a version patch when merged
label
Dec 20, 2023
Can you update the changelog as per the PR comments please 👍🏼 |
Done. |
damacus
previously approved these changes
Jan 3, 2024
Please look into failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
given ports argument als array of strings like:
generates in
/etc/default/ufw-chef.rules
file:ufw allow in proto tcp to any port 389,443,464,636,80,88 from 10.10.10.10 comment "allow some ports"
after this fix:
ufw allow in proto tcp to any port 80,88,389,443,464,636 from 10.10.10.10 comment "allow some ports"
Issues Resolved
Correct generation of firewall rules.
Check List
## Unreleased