-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXP: try out lower level pyo3 API #552
Open
ctb
wants to merge
32
commits into
refactor_gather_csv
Choose a base branch
from
branch_api_2
base: refactor_gather_csv
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctb
changed the title
EXP: steal code from branch_api
EXP: try out lower level pyo3 API
Dec 21, 2024
…water into branch_api_2
…water into branch_api_2
…water into branch_api_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy over useful code from #428, to try anew.
This PR -
Collection
,Manifest
, andRecord
;load_from
hook to support loading files via new wrapping;Next steps:
Record
to provide getters for private elementsksize
,scaled
,num
,with_abundance
, andn_hashes
;Index
protocol - in particular, providing sketches that are compatible with the FFI layer, and supportingfind
,prefetch
, andpeek
;Other notes:
pyo3-ffi - might this let us work directly with FFI interface in sourmash?
Limit to rocksdb loading? And/or provide env variable switch to turn loading on and off?