Add file output to ili2pg export from DB algorithm #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -463,7 +463,8 @@ def initAlgorithm(self, config=None): | |||
| self.ILIMODELS, | |||
| self.tr('Interlis models'))) | |||
| self.addParameter(QgsProcessingParameterFileDestination( | |||
| self.XTF, description="Interlis transfer output file")) | |||
| self.OUTPUT, | |||
There was a problem hiding this comment.
Why rename the parameter here? Does it have to be named OUTPUT?
There was a problem hiding this comment.
No, it does not. But looking in the docs and in other Python processing algs, it seems to be kind of a convention to name the output parameter OUTPUT. Technically it doesn't matter.
|
@webrian Thanks for the PR!! I commented on one of your changes :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ili2pg export from DB algorithm doesn't return anything. As long as the algorithm is run from the processing toolbox this is not an issue. But if the algorithm is used in model it would be helpful to return the filepath of the exported Interlis file, in order to use the file in a following algorithm as an input.
In the following model the exported file is uploaded to a FTP server (namely to an Interlis checker):