Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kind and display_name to SymbolInformation #361

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soohoonc
Copy link

Started adding support for the kind and display_name field for SymbolInformation.

Test plan

Currently tested on couple of personal typescript repos, may need to update snapshot tests (not totally sure what the process here is like)

@soohoonc soohoonc marked this pull request as ready for review July 24, 2024 01:51
@soohoonc soohoonc marked this pull request as draft July 24, 2024 16:57
@soohoonc
Copy link
Author

mapping from typescript types to symbolInformation is incomplete/may be inaccurate, will work on this a bit more.

@varungandhi-src
Copy link
Contributor

varungandhi-src commented Aug 12, 2024

Sorry, just saw this PR after #360

We should add a magic comment to display the kinds and symbol names in a specific file, and add new snapshotting logic for that. After that, you can update the snapshots. https://github.com/sourcegraph/scip-typescript/blob/main/Development.md

Existing snapshots should be unaffected, only the new file containing this magic comment should be affected.

Example of how we do this in scip-clang. https://sourcegraph.com/github.com/sourcegraph/scip-clang/-/blob/test/index/docs/docs.cc?L1-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants