E2E: V2 Playwright framework foundations (#4706)

Co-authored-by: Keegan Carruthers-Smith <[email protected]>

.gitignore

@@ -7,6 +7,7 @@ out/
 .env
 .idea/
 .run/
+.test/
 **/*.iml
 **/*.vsix
 index.scip

.vscode/settings.json

@@ -26,6 +26,9 @@
   },
   "editor.insertSpaces": true,
   "cSpell.words": ["Supercompletion", "Supercompletions"],
+  "[json]": {
+    "editor.defaultFormatter": "biomejs.biome",
+  },
   "[typescript]": {
     "editor.defaultFormatter": "biomejs.biome"
   },

agent/src/cli/cody-bench/strategy-fix.ts

@@ -3,7 +3,7 @@ import { PromptString, ps } from '@sourcegraph/cody-shared'
 import { glob } from 'glob'
 import * as vscode from 'vscode'
 import { ProtocolTextDocumentWithUri } from '../../../../vscode/src/jsonrpc/TextDocumentWithUri'
-import { fileExists } from '../../../../vscode/src/local-context/download-symf'
+import { pathExists } from '../../../../vscode/src/local-context/utils'
 import { redactAuthorizationHeader } from '../../../../vscode/src/testutils/CodyPersister'
 import { AgentTextDocument } from '../../AgentTextDocument'
 import { TestClient } from '../../TestClient'
@@ -31,7 +31,7 @@ export async function evaluateFixStrategy(
             token: options.srcAccessToken,
         },
     })
-    if (!(await fileExists(path.join(options.workspace, 'node_modules')))) {
+    if (!(await pathExists(path.join(options.workspace, 'node_modules')))) {
         // Run pnpm install only when `node_modules` doesn't exist.
         await runVoidCommand(options.installCommand, options.workspace)
     }

agent/src/cli/cody-bench/strategy-unit-test.ts

@@ -3,7 +3,7 @@ import _ from 'lodash'
 import * as vscode from 'vscode'
 import yaml from 'yaml'
 import type { RpcMessageHandler } from '../../../../vscode/src/jsonrpc/jsonrpc'
-import { fileExists } from '../../../../vscode/src/local-context/download-symf'
+import { fileExists } from '../../../../vscode/src/local-context/utils'
 import { redactAuthorizationHeader } from '../../../../vscode/src/testutils/CodyPersister'
 import { TestClient } from '../../TestClient'
 import { getLanguageForFileName } from '../../language'

lib/shared/src/sourcegraph-api/graphql/url.ts

@@ -1,5 +1,3 @@
-import { trimEnd } from 'lodash'
-
 const GRAPHQL_URI = '/.api/graphql'
 
 interface BuildGraphQLUrlOptions {
@@ -12,5 +10,5 @@ interface BuildGraphQLUrlOptions {
 export const buildGraphQLUrl = ({ request, baseUrl }: BuildGraphQLUrlOptions): string => {
     const nameMatch = request ? request.match(/^\s*(?:query|mutation)\s+(\w+)/) : ''
     const apiURL = `${GRAPHQL_URI}${nameMatch ? `?${nameMatch[1]}` : ''}`
-    return baseUrl ? new URL(trimEnd(baseUrl, '/') + apiURL).href : apiURL
+    return baseUrl ? new URL(apiURL, baseUrl).href : apiURL
 }

lib/shared/src/utils.ts

@@ -99,3 +99,25 @@ export function createSubscriber<T>(): Subscriber<T> {
 export function nextTick() {
     return new Promise(resolve => process.nextTick(resolve))
 }
+
+export type SemverString<Prefix extends string> = `${Prefix}${number}.${number}.${number}`
+
+export namespace SemverString {
+    const splitPrefixRegex = /^(?<prefix>.*)(?<version>\d+\.\d+\.\d+)$/
+    export function forcePrefix<P extends string>(prefix: P, value: string): SemverString<P> {
+        const match = splitPrefixRegex.exec(value)
+        if (!match || !match.groups?.version) {
+            throw new Error(`Invalid semver string: ${value}`)
+        }
+        return `${prefix}${match.groups?.version}` as SemverString<P>
+    }
+}
+
+type TupleFromUnion<T, U = T> = [T] extends [never]
+    ? []
+    : T extends any
+      ? [T, ...TupleFromUnion<Exclude<U, T>>]
+      : []
+
+// Helper type to ensure an array contains all members of T
+export type ArrayContainsAll<T extends string> = TupleFromUnion<T>