Simplify WebView initialization #98
Draft
+407
−1,174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's treat it as an experiment for now. There are some nice concepts here, that we could potentially bring to the main, if it will be stable enough. |
added 2 commits
September 27, 2024 11:47
# Conflicts: # src/Cody.Core/Infrastructure/WebViewsManager.cs # src/Cody.VisualStudio.Tests/ChatLoggedBasicTests.cs # src/Cody.VisualStudio.Tests/ChatNotLoggedStateTests.cs # src/Cody.VisualStudio/Client/AgentClientProviderOptions.cs # src/Cody.VisualStudio/CodyPackage.cs
|
i tried building from this branch but my chat is stuck in loading:
|
|
@abeatrix I have made improvements to the code, please check it out |
I got a new error on starting the build |
added 2 commits
October 2, 2024 16:08
# Conflicts: # src/Cody.UI/Views/MainView.xaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the code associated with webview. The changes allow to:
Most of the code related to webview is now in the
WebViewNotificationHandlers.csandCodyWebView.csfiles. The code takes advantage of the fact that webview loads files from disk and no longer needs the results returned by the agent during initialization (e.g. SetHtml notification). This means that the webview can now load independently of notifications from the agent which greatly simplifies the entire code.