improve backport experience #7
Merged
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaellzc
commented
Sep 8, 2023
Comment on lines
-306
to
+316
| const runUrl = `${serverUrl}/${owner}/${repo}/actions/runs/${runId}/jobs/${runNumber}`; | ||
| const runUrl = `${serverUrl}/${owner}/${repo}/actions/runs/${runId}`; |
There was a problem hiding this comment.
this link is broken
e.g., https://github.com/sourcegraph/sourcegraph/actions/runs/6123459521/jobs/15021
the job id is not exposed from the context, let's just go as far as the summary page of the workflow run
it's good enough
michaellzc
commented
Sep 8, 2023
| "```", | ||
| "", | ||
| "- [ ] Follow above instructions to backport the commit.", | ||
| `- [ ] Create a pull request where the \`base\` branch is \`${base}\` and the \`compare\`/\`head\` branch is \`${head}\`., [click here to create the pull request](https://github.com/sourcegraph/sourcegraph/compare/${base}...${head}?expand=1).`, |
There was a problem hiding this comment.
why not just send people directly to the page to create the pr
|
I think we would need to make a new release, then update the version we use in the sg/sg repo |
I'll kick off a release. We don't need to update the version in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current experience is quite bad when you run into conflict, I prefer to have commands I can just copy and paste to resume the process
post-creation step is easy to miss, i.e., remove
release-blockerlabelhttps://github.com/sourcegraph/sourcegraph/pull/56448#issuecomment-1711833003