fix(core): WF| 'Save' button gets disabled when “Is past today“ is selected in 'Date/Time' column under 'Add Check Value' event #70
Conversation
fix you can add Valid WF GH-68
|
==== Karma Test Coverage ==== |
| if (typeof node.node.state.get('value') !== 'undefined') { | ||
| valueExists = true; | ||
| } else if ( | ||
| node.node.state.get('condition') === ConditionTypes.PastToday |
There was a problem hiding this comment.
This is a suggestion for a small improvement that is not mandatory to follow. It involves removing one minor stuff.
let valueExists = false;
if (typeof node.node.state.get('value') !== 'undefined' || node.node.state.get('condition') === ConditionTypes.PastToday) {
valueExists = true;
} else {
valueExists = !!node.node.state.get('value');
}the conditions are combined into a single 'if' statement, which checks if either the 'value' is defined or the condition is 'PastToday'.
There was a problem hiding this comment.
@Deepika516 please change this as well
There was a problem hiding this comment.
This can be disregarded as there may be more conditions in the future and need to add more "if" conditions.
|
==== Karma Test Coverage ==== |
|
==== Karma Test Coverage ==== |
WF| 'Save' button gets disabled when “Is past today“ is selected in 'Date/Time' column under 'Add Check Value' event
GH-68
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #68
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: