-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): make model and respository customizable #124
base: master
Are you sure you want to change the base?
Conversation
now user can use the default as well as their custom respository GH-121
both the readme have to be in sync GH-121
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we doing this ? Who requested ?
docs/README.md
Outdated
|
||
```ts | ||
import {AuditLog} from '@sourceloop/auidt-log/'; | ||
import {AuditLogRepository} from '@sourceloop/auidt-log/sequelize'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spell check
This is in respect to the issue raised by community |
@yeshamavani Any update on this PR? |
update the docs GH-121
Quality Gate passedIssues Measures |
This PR is under review I will update you once we release this soon |
now user can use the default as well as their custom respository
GH-121
Description
The mixin now accepts two optional parameters for audit model and repository
also now the repositories dont have the tenantGuard() by default it can be binded based on condition
Fixes #121
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Created a sample app and tested that
Checklist: