Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make model and respository customizable #124

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yeshamavani
Copy link
Contributor

@yeshamavani yeshamavani commented Jun 13, 2024

now user can use the default as well as their custom respository

GH-121

Description

The mixin now accepts two optional parameters for audit model and repository
also now the repositories dont have the tenantGuard() by default it can be binded based on condition

Fixes #121

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Created a sample app and tested that

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

now user can use the default as well as their custom respository

GH-121
both the readme have to be in sync

GH-121
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@samarpan-b samarpan-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this ? Who requested ?

docs/README.md Outdated

```ts
import {AuditLog} from '@sourceloop/auidt-log/';
import {AuditLogRepository} from '@sourceloop/auidt-log/sequelize';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spell check

@yeshamavani
Copy link
Contributor Author

Why are we doing this ? Who requested ?

This is in respect to the issue raised by community
#121

@yeshamavani yeshamavani changed the title fix(core): make model and resposiory customizable fix(core): make model and respository customizable Nov 5, 2024
@mrbatista
Copy link

@yeshamavani Any update on this PR?

Copy link

sonarqubecloud bot commented Nov 6, 2024

@yeshamavani
Copy link
Contributor Author

yeshamavani commented Nov 6, 2024

@yeshamavani Any update on this PR?

This PR is under review I will update you once we release this soon
Feel free to review this PR and we are open for suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make model and repository customizable
3 participants