Make Python operations stricter about types (#1708)

* Make Python operations stricter about types * format * fix test * format * Address review * fix tests * format
source-academy · Jun 3, 2024 · 05287c5 · 05287c5
1 parent 24c0aa3
commit 05287c5
Show file tree

Hide file tree

Showing 3 changed files with 152 additions and 25 deletions.
diff --git a/src/stdlib/__tests__/__snapshots__/pylib.ts.snap b/src/stdlib/__tests__/__snapshots__/pylib.ts.snap
@@ -97,7 +97,7 @@ Object {
   "code": "True * 2",
   "displayResult": Array [],
   "numErrors": 1,
-  "parsedErrors": "Line 1: Error: Expected number on left hand side of operation, got boolean.",
+  "parsedErrors": "Line 1: Error: Invalid types for multiply operation: boolean, bigint",
   "result": undefined,
   "resultStatus": "error",
   "visualiseListResult": Array [],

diff --git a/src/stdlib/__tests__/pylib.ts b/src/stdlib/__tests__/pylib.ts
@@ -98,9 +98,7 @@ test('cannot multiply non-number values', () => {
     True * 2
   `,
     { chapter: Chapter.PYTHON_1, native: true }
-  ).toMatchInlineSnapshot(
-    `"Line 1: Error: Expected number on left hand side of operation, got boolean."`
-  )
+  ).toMatchInlineSnapshot(`"Line 1: Error: Invalid types for multiply operation: boolean, bigint"`)
 })
 
 test('dividing integer and float is ok', () => {