Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Vite #2996

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft

Migrate to Vite #2996

wants to merge 34 commits into from
+625 −176

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented May 12, 2024 •
edited
Loading

Description

Supersedes #2327.
Supersedes #2508.

Closes #2933.
Will need to remove CRA compatibility layers after (part of #2990).

TODO:

  • Devserver
  • Build
  • Somehow Admin Panel renders as an iframe that blocks all subsequent interactions (resolved in ce5a1c6)
  • GameSimulator crashes with runtime error (fixed by Refactor game simulator #2997)
  • Test scripts
  • Manually test everything
  • Java-slang not working
  • C-slang not working
  • Service worker

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 requested a review from chownces May 12, 2024 13:41
@RichDom2185 RichDom2185 self-assigned this May 12, 2024
@RichDom2185 RichDom2185 mentioned this pull request May 12, 2024
Closed
7 tasks
@RichDom2185 RichDom2185 requested a review from sayomaki May 13, 2024 19:32
@benmurphyy benmurphyy mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chownces chownces Awaiting requested review from chownces

@sayomaki sayomaki Awaiting requested review from sayomaki

At least 1 approving review is required to merge this pull request.

Assignees

@RichDom2185 RichDom2185

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Vite
1 participant
@RichDom2185