Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie Page UI Optimization #336

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

anamika7153
Copy link
Contributor

Related Issue

Closes: #269

Description of Changes

Checklist:

  • My code adheres to the established style guidelines of this project.
  • I have conducted a self-review of my code.
  • I have included comments in areas that may be difficult to understand.
  • I have made corresponding updates to the project documentation.
  • My changes have not introduced any new warnings.

Screenshots

Original Updated
image image
Original Updated
image image

@vercel
Copy link

vercel bot commented Jun 25, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @sourabhsikarwar on Vercel.

@sourabhsikarwar first needs to authorize it.

@anamika7153
Copy link
Contributor Author

@sourabhsikarwar please review :)

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scene-movie-platform ❌ Failed (Inspect) Mar 19, 2024 2:05pm

@anamika7153
Copy link
Contributor Author

Added release year and genre too.

Screenshot 2023-06-28 2209511

@anamika7153
Copy link
Contributor Author

@sourabhsikarwar Please merge it as I have to make a PR of Movie-details issue which contains the UI code of this PR. Please merge it so that I can create PR for that and both the PRs can be counted separately.

@anamika7153
Copy link
Contributor Author

@sourabhsikarwar Also, after someone else's PR the Movie page UI has got totally different from the website's UI. This PR really needs to b merged asap.

This is the current Movie page UI and it remains same on both the modes (light and dark) :

image

This is the UI of this PR:

248588828-329f441e-4c03-4c8a-bf45-e1dacabf70c6

@anamika7153
Copy link
Contributor Author

@sourabhsikarwar Also, after someone else's PR the Movie page UI has got totally different from the website's UI. This PR really needs to b merged asap.

This is the current Movie page UI and it remains same on both the modes (light and dark) :

image ### This is the UI of this PR: 248588828-329f441e-4c03-4c8a-bf45-e1dacabf70c6

@sourabhsikarwar

@anamika7153
Copy link
Contributor Author

anamika7153 commented Jul 10, 2023

@sourabhsikarwar please merge it. My further PRs are on hold

@anamika7153
Copy link
Contributor Author

Also, current version looks like this on mobile :

image

@anamika7153 anamika7153 marked this pull request as draft July 12, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Movie page UI optimization
2 participants