Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize folder structure to match Vue idioms #39

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Conversation

steinbro
Copy link
Member

@steinbro steinbro commented Jul 8, 2024

  • Move icons + sounds out of src into assets
  • Move App.vue, main.css directly under src
  • Reorganize JS files into store, utils directly under src

@sebastianovide did I break anything in the PWA/Android app?

@sebastianovide
Copy link
Contributor

did I break anything in the PWA/Android app?

yep. something happened to the heading: TypeError: myLocation.sstHeading is not a function

@steinbro
Copy link
Member Author

steinbro commented Jul 8, 2024

Grr, typo. How about now? Maybe next I'll convert to TypeScript to catch those at compile time :)

@sebastianovide
Copy link
Contributor

yep, +1 for TypeScript ....

I don't see the errors any more but I cannot see the arrow neither...

@steinbro
Copy link
Member Author

steinbro commented Jul 8, 2024

I don't see the errors any more but I cannot see the arrow neither...

Yeah, noticed that too, filed as #40.

Do you see the arrow on the currently deployed site? I'm concerned this was an earlier regression not related to this PR.

@sebastianovide
Copy link
Contributor

neither... It did happened before...

@steinbro
Copy link
Member Author

steinbro commented Jul 8, 2024

OK, try this branch again.

I think there were at least two bugs I introduced that broke the compass on both iOS and everywhere else. The permissions issue in #40 was due to my turning the active mode setting into a Vue reactive variable and moving this logic into a watch handler instead of leaving it in the click handler where it apparently needs to be.

@steinbro steinbro merged commit 90c7b6f into main Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants