Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed voices not being populated in web #34

Closed

Conversation

sebastianovide
Copy link
Contributor

and missing the default

@steinbro
Copy link
Member

steinbro commented Jul 6, 2024

I can reproduce the regression (voice list is empty on first load) on Firefox + Windows, but this patch doesn't seem to fix it. The voice list is populated if I simply refresh the page, but if I quit and restart the browser, it's empty again.

@sebastianovide
Copy link
Contributor Author

very odd.... in fact that was a hack more than a fix after different trials an errors.... I've opened a ticket in capacitor-community/text-to-speech#130

@steinbro
Copy link
Member

steinbro commented Jul 6, 2024

I think I fixed it in 84fa8fa on main. Does it work for you?

In the process of the Vue conversion, I inadvertently dropped the window.speechSynthesis.onvoiceschanged event binding. I take it that at least in some browsers there's some delay between page load and TTS being available, so attempting to load voices may only succeed after that event is first triggered.

@sebastianovide
Copy link
Contributor Author

o yep... it works 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants