Assign default value to newly added derived column upon reload (apach…

…e#12648)
soumitra-st · Mar 18, 2024 · 1f668c7 · 1f668c7
1 parent 7c6ce9d
commit 1f668c7
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/...ache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java b/...ache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
@@ -368,14 +368,10 @@ protected boolean createColumnV1Indices(String column)
           for (String argument : arguments) {
             ColumnMetadata columnMetadata = _segmentMetadata.getColumnMetadataFor(argument);
             if (columnMetadata == null) {
-              LOGGER.warn("Skip creating derived column: {} because argument: {} does not exist in the segment", column,
-                  argument);
-              if (errorOnFailure) {
-                throw new RuntimeException(String.format(
-                    "Failed to create derived column: %s because argument: %s does not exist in the segment", column,
-                    argument));
-              }
-              return false;
+              LOGGER.warn("Assigning default value to derived column: {} because argument: {} does not exist in the "
+                  + "segment", column, argument);
+              createDefaultValueColumnV1Indices(column);
+              return true;
             }
             // TODO: Support creation of derived columns from forward index disabled columns
             if (!_segmentWriter.hasIndexFor(argument, StandardIndexes.forward())) {