createUserWithEmailAndPassword returns object with user property #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aChanges is true.
…l the onSnapshot callbacks no mater where the flush is called from.
According to Google, this FirebaseAuth method should return a UserCredential instead of just a User. https://firebase.google.com/docs/reference/node/firebase.auth.Auth#createUserWithEmailAndPassword
When a new user is created in firebase, they are automatically signed in. Source: https://firebase.google.com/docs/auth/web/password-auth
This reverts commit 64d0b8a.
When a new user is created in firebase, they are automatically signed in. Source: https://firebase.google.com/docs/auth/web/password-auth
* issue-81-onsnapshot: Move onSnapshot handers to the queue so that a call to flush will call the onSnapshot callbacks no mater where the flush is called from. onSnapshot should call callback if no data changed and includeMetadataChanges is true. Add onSnapshot functionality to doc, collection and query
* issue-81-onsnapshot: onSnapshot should call immediatly and then after data changes.
Boyko/fieldvalue array
Bc/order by onsnapshot merge
|
Any news on getting this merged? This is blocking my upgrading the |
soumak77 hasn't been active on github since last September and I'm not sure anyone else has write access. You can use my fork for now and I could merge the other PRs |
added 4 commits
August 27, 2019 10:19
added 3 commits
August 27, 2019 10:37
Merge master into _updateTime
Support specifying _updateTime and _createTime when mocking firestore doc
|
Hi all, It has transpired that @soumak77 passed away last October. We are in the process of transferring ownership of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Google, this FirebaseAuth method should return a
UserCredential instead of just a User (the User is the value of the user property of UserCredential).
https://firebase.google.com/docs/reference/node/firebase.auth.Auth#createUserWithEmailAndPassword