SOT-127: FRI implementation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
ktokto313
reviewed
May 10, 2024
zk-steve
force-pushed
the
fri
branch
2 times, most recently
from
58c600d to
9992e3f
Compare
zk-steve
requested review from
0x5ea000000,
zk-steve,
hduoc2003,
Draply and
bjergsen243
zk-steve
force-pushed
the
fri
branch
2 times, most recently
from
07e3551 to
28cc8e4
Compare
zk-steve
reviewed
May 19, 2024
zk-steve
reviewed
May 19, 2024
zk-steve
reviewed
May 19, 2024
zk-steve
reviewed
May 19, 2024
zk-steve
approved these changes
May 19, 2024
|
zk-steve
approved these changes
Jun 26, 2024
|
|
||
| /// Represents the state of FRI variables in each interaction. | ||
| #[derive(Clone)] | ||
| pub struct FriLayer<F: PrimeField> { |
Check warning
Code scanning / clippy
field coset is never read Warning
| /// Merkle tree constructed from the evaluated values of the committed polynomial at a subset Omega of F. | ||
| pub merkle_tree: MerkleTree<F>, | ||
| /// Coset value used for polynomial evaluation. | ||
| pub coset: F, |
Check warning
Code scanning / clippy
field coset is never read Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.