Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/vec_to_bytes_le #20

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix/vec_to_bytes_le #20

merged 1 commit into from
Sep 12, 2024

Conversation

Draply
Copy link
Member

@Draply Draply commented Sep 12, 2024

Check List

  • Don't forget to squash commits into meaningful chunks before merging
  • Check every test passed.
  • Did you split imports into std and custom parts?
  • Have you updated the consts in ORN?
  • Have you run ORN with the latest version?
  • Check your commit messages.
  • Have you added meaningful comments?
  • Don't forget to optimize gas cost!
    • Calling vector::length() multiple times is expensive (e.g. in loops), save it to a variable instead.
    • Consider using consts for things that can be pre-computed.
    • pow(2, x) => (1 << x+1)
    • inline short functions to save gas.
    • Find all vector::empty() in all files and replace them with the first append
    • Use vector::*_reverse_*() version to save gas.
  • Check Visibility of functions

@Draply Draply force-pushed the fix/vec_to_bytes_le branch from 47fa9cc to edbde10 Compare September 12, 2024 10:42
@0x5ea000000 0x5ea000000 merged commit df02eee into main Sep 12, 2024
1 check passed
@0x5ea000000 0x5ea000000 deleted the fix/vec_to_bytes_le branch September 12, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants