Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mzk 41 layout7 #18

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Mzk 41 layout7 #18

merged 2 commits into from
Sep 12, 2024

Conversation

hduoc2003
Copy link
Contributor

Check List

  • Don't forget to squash commits into meaningful chunks before merging
  • Check every test passed.
  • Did you split imports into std and custom parts?
  • Have you updated the consts in ORN?
  • Have you run ORN with the latest version?
  • Check your commit messages.
  • Have you added meaningful comments?
  • Don't forget to optimize gas cost!
    • Calling vector::length() multiple times is expensive (e.g. in loops), save it to a variable instead.
    • Consider using consts for things that can be pre-computed.
    • pow(2, x) => (1 << x+1)
    • inline short functions to save gas.
    • Find all vector::empty() in all files and replace them with the first append
    • Use vector::*_reverse_*() version to save gas.
  • Check Visibility of functions

Copy link

linear bot commented Sep 11, 2024

MZK-41 Layout7 contracts

@hduoc2003 hduoc2003 requested a review from zk-steve September 11, 2024 07:10
@hduoc2003 hduoc2003 merged commit a633d4a into main Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants