Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split into multiple packages #16

Merged
merged 2 commits into from
Aug 23, 2024
Merged

refactor: split into multiple packages #16

merged 2 commits into from
Aug 23, 2024

Conversation

zk-steve
Copy link
Contributor

@zk-steve zk-steve commented Aug 23, 2024

Check List

  • Don't forget to squash commits into meaningful chunks before merging
  • Check every test passed.
  • Did you split imports into std and custom parts?
  • Have you updated the consts in ORN?
  • Have you run ORN with the latest version?
  • Check your commit messages.
  • Have you added meaningful comments?
  • Don't forget to optimize gas cost!
    • Calling vector::length() multiple times is expensive (e.g. in loops), save it to a variable instead.
    • Consider using consts for things that can be pre-computed.
    • pow(2, x) => (1 << x+1)
    • inline short functions to save gas.
    • Find all vector::empty() in all files and replace them with the first append
    • Use vector::*_reverse_*() version to save gas.
  • Check Visibility of functions

@Draply Draply force-pushed the split-packages branch 11 times, most recently from 25abe29 to 8bf2e6b Compare August 23, 2024 11:21
@Draply Draply merged commit da05a60 into main Aug 23, 2024
1 check passed
@Draply Draply deleted the split-packages branch August 23, 2024 11:25
zk-steve added a commit that referenced this pull request Aug 28, 2024
* refactor: split into multiple packages

* fix: navori ci

---------

Co-authored-by: hduoc2003 <[email protected]>
Co-authored-by: draply <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants