Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: aptos da client #9

Merged
merged 7 commits into from
Aug 29, 2024
Merged

feat: aptos da client #9

merged 7 commits into from
Aug 29, 2024

Conversation

Tranduy1dol
Copy link
Member

@Tranduy1dol Tranduy1dol commented Aug 1, 2024 •
edited by zk-steve
Loading

Check List

  • Don't forget to squash commits into meaningful chunks before merging
  • Check every test passed.
  • Did you split imports into std, third parties, and custom parts?
  • Format your code.
    • cargo fmt
    • cargo clippy
    • taplo fmt --config taplo/taplo.toml
  • Check unwrap, expect().
  • Check clone().
  • Check your commit messages.
  • Have you added meaningful comments.

@Tranduy1dol Tranduy1dol force-pushed the Mzk-29-Aptos-DA-Layer-new branch from ab7dec4 to 4b91434 Compare August 5, 2024 07:32
@Tranduy1dol Tranduy1dol force-pushed the Mzk-29-Aptos-DA-Layer-new branch from 4b91434 to 12593fb Compare August 5, 2024 07:53
@Tranduy1dol Tranduy1dol force-pushed the Mzk-29-Aptos-DA-Layer-new branch from 12593fb to 1032b7b Compare August 6, 2024 08:01
@Tranduy1dol Tranduy1dol force-pushed the Mzk-29-Aptos-DA-Layer-new branch from d2cd628 to 514e81e Compare August 6, 2024 08:16
zk-steve
zk-steve reviewed Aug 6, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
@Tranduy1dol Tranduy1dol force-pushed the Mzk-29-Aptos-DA-Layer-new branch from ff50b4f to 64581a0 Compare August 7, 2024 11:42
@0x5ea000000 0x5ea000000 changed the base branch from main to aptos August 8, 2024 09:07
0x5ea000000
0x5ea000000 reviewed Aug 8, 2024
View reviewed changes
Copy link

@0x5ea000000 0x5ea000000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the comment

@Tranduy1dol Tranduy1dol self-assigned this Aug 12, 2024
@zk-steve zk-steve force-pushed the Mzk-29-Aptos-DA-Layer-new branch from 03d79b7 to cd739bb Compare August 12, 2024 04:02
@Tranduy1dol Tranduy1dol force-pushed the Mzk-29-Aptos-DA-Layer-new branch from cd739bb to 0afaaef Compare August 12, 2024 05:11
zk-steve
zk-steve reviewed Aug 20, 2024
View reviewed changes
bash.sh Outdated Show resolved Hide resolved
zk-steve
zk-steve reviewed Aug 20, 2024
View reviewed changes
crates/da-clients/aptos/src/helper.rs Outdated
)
.sender(sender.address())
.sequence_number(i)
.max_gas_amount(100000)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30000

zk-steve
zk-steve reviewed Aug 21, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
Tranduy1dol and others added 3 commits August 21, 2024 03:01
@Tranduy1dol @zk-steve
feat: Aptos Settelement Layer (#7)
1b5ee22 
* feat(aptos_settlement_client): update state kzg & update state & verify inclusion

* test(aptos_settlement_client): add update_state, state_block_number unit test

* fix: dependencies

* refactor code

* feat: add submodule ionia

* feat(aptos_settlement_client): update state kzg & update state & verify inclusion

* test(aptos_settlement_client): add update_state, state_block_number unit test

* fix: dependencies

* refactor code

* feat: add submodule ionia

* refactor code

* refactor code

---------

Co-authored-by: Steve Nguyen <[email protected]>
@zk-steve
feat: pull request template
8952ecc
@dependabot
Bump ionia from 3a15977 to fe4cd5a (#10)
a94cb7c 
Bumps [ionia](https://github.com/sota-zk-labs/ionia) from `3a15977` to `fe4cd5a`.
- [Commits](sota-zk-labs/ionia@3a15977...fe4cd5a)

---
updated-dependencies:
- dependency-name: ionia
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Tranduy1dol Tranduy1dol force-pushed the Mzk-29-Aptos-DA-Layer-new branch 2 times, most recently from d2d0465 to bc18f1c Compare August 28, 2024 04:47
Tranduy1dol and others added 3 commits August 28, 2024 04:51
@Tranduy1dol
feat: Aptos Da Client
98c9e05
@heemankv @apoorvsadana @Tranduy1dol
feat: Data Submission Worker Integration. (madara-alliance#51)
62fc578 
* update: DA job draft #1

* docs: changelog updated

* update: is_worker_enabled impl & usage in da_submission, removal of String from VerificationFailed

* update: renamed  to

* update: run worker only if it's enabled using is_worker_enabled check

* build: linter fixes

* Update CHANGELOG.md

Co-authored-by: Apoorv Sadana <[email protected]>

* update: limit_to_one on get_jobs_by_status

* update: removed get_last_successful_job_by_type, added get_latest_job_by_type_and_status

* update: added error to job metadata

* update: pr resolution, simplifying get_jobs_by_status, rejected status in verify_jobs

* update: linting fixes

* Update crates/orchestrator/src/jobs/mod.rs

Co-authored-by: Apoorv Sadana <[email protected]>

* update: removing .expect from mongodb mod file

* update: fixed testcase for snos worker

* chore: correct variable name

* update: added support to check againt multiple status - is_worker_enabled, get_jobs_by_statuses

* docs: rewrote 1 job per block assumption

* docs: DataSubmissionWorker -> DataAvailabilitySynchronizer

* chore: liniting fix

* update: changed name : DataAvailabilitySynchronizer -> DataSubmissionWorker

---------

Co-authored-by: Apoorv Sadana <[email protected]>
@ocdbytes @heemankv
@EvolveArt @Tranduy1dol
Feat : add testing fixtures and a basic test (madara-alliance#52)
8c6ded1 
* feat : added tests for increasing coverage

* feat : added mongo db tests and fixtures and updated the ci for tests

* update : removed unwanted fixtures

* update : removed unwanted fixtures

* update : added mongo db runner in ci

* update : added mongo db runner in ci

* update : added mongo db runner in ci

* update : updated with new changes and ci

* update : updated test cases for s3 client

* update : added .env.test file in the commit

* feat : added database necessary tests

* feat : added database necessary tests

* Revert "feat : added database necessary tests"

This reverts commit 65d66e6.

* Revert "feat : added database necessary tests"

This reverts commit 906a1eb.

* update: Replaced Build_Config Fixture with TestConfigBuilder

* update : config update

* update : test_put_and_get_data_s3 test

* update: moved testconfigbuilder to tests/config.rs & added docs , drop all collections not just jobs

* feat : updated test config and added config type to aws s3 config

* chore: resolved pr comments

* Update crates/orchestrator/src/tests/database/mod.rs

Co-authored-by: 0xevolve <[email protected]>

* feat : lint fix

* fix : coverage tests fix

* fix : test fix

---------

Co-authored-by: Heemank Verma <[email protected]>
Co-authored-by: 0xevolve <[email protected]>
@Tranduy1dol Tranduy1dol force-pushed the Mzk-29-Aptos-DA-Layer-new branch from bc18f1c to 1a8c48a Compare August 28, 2024 04:51
@ocdbytes @heemankv
@apoorvsadana @EvolveArt @Tranduy1dol
Feat : job handler tests (madara-alliance#67)
2a75aef 
* feat : added tests for increasing coverage

* feat : added mongo db tests and fixtures and updated the ci for tests

* update : removed unwanted fixtures

* update : removed unwanted fixtures

* update : added mongo db runner in ci

* update : added mongo db runner in ci

* update : added mongo db runner in ci

* update : updated with new changes and ci

* update : updated test cases for s3 client

* update : added .env.test file in the commit

* feat : added database necessary tests

* feat : added database necessary tests

* Revert "feat : added database necessary tests"

This reverts commit 65d66e6.

* Revert "feat : added database necessary tests"

This reverts commit 906a1eb.

* update: Replaced Build_Config Fixture with TestConfigBuilder

* update : config update

* update : test_put_and_get_data_s3 test

* update: moved testconfigbuilder to tests/config.rs & added docs , drop all collections not just jobs

* feat : create job test case error returning

* mock job handler

* feat : added jobs test and modified worker tests

* feat : added queue checks to tests and revamped some tests

* feat : updated tests and resolved comments

* feat : updated test config and added config type to aws s3 config

* feat : updated tests and test names

* feat : lint fixes

* feat : lint fixes

* feat : lint fixes

* chore: resolved pr comments

* Update crates/orchestrator/src/tests/database/mod.rs

Co-authored-by: 0xevolve <[email protected]>

* chore : lint fixes

* feat : lint fix

* fix : coverage tests fix

* fix : test fix

* fix : updated region in localstack .env.test

* feat : updated region

* debug : added debug log to github ci

* feat : updated queue code for test fixes

* fix : sqs region fix

* debug : added debug logs for ci debugging

* feat : added override endpoint to queue url in producer and consumer

* feat : added override endpoint to queue url in producer and consumer

* fix : removed logs and refactored the code

* chore : refactor code

---------

Co-authored-by: Heemank Verma <[email protected]>
Co-authored-by: apoorvsadana <[email protected]>
Co-authored-by: 0xevolve <[email protected]>
@Tranduy1dol Tranduy1dol force-pushed the Mzk-29-Aptos-DA-Layer-new branch from 1a8c48a to 2a75aef Compare August 28, 2024 05:31
zk-steve
zk-steve reviewed Aug 29, 2024
View reviewed changes
.github/workflows/pull-request.yml
Comment on lines +7 to +9
branches: [aptos]
push:
branches: [main]
branches: [aptos]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@Tranduy1dol Tranduy1dol merged commit 806f6be into aptos Aug 29, 2024
3 of 6 checks passed
@Tranduy1dol Tranduy1dol deleted the Mzk-29-Aptos-DA-Layer-new branch September 16, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5ea000000 0x5ea000000 0x5ea000000 left review comments

@zk-steve zk-steve zk-steve approved these changes

Assignees

@Tranduy1dol Tranduy1dol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tranduy1dol @0x5ea000000 @zk-steve @heemankv @ocdbytes